Farmer plot cache #2550
Merged
Farmer plot cache #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This causes problems on Windows, see al8n/fs4-rs#10 If I can't resolve that, I'll update PR to not cache pieces into plot file on Windows temporarily. UPD: Seems to be related to VM environment (likely virtio). |
shamil-gadelshin
approved these changes
Feb 26, 2024
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub(crate) enum MaybePieceStoredResult { |
There was a problem hiding this comment.
ProbabilisticStoredPieceResult ??
There was a problem hiding this comment.
I agree the name is a bit awkward. It is not necessarily probabilistic at the moment it is returned, but since there is no lock held throughout, things might change by the time this information is acted upon. Not sure ProbabilisticStoredPieceResult is much better option, but definitely looking for better alternatives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously farmer only had piece cache as it supposed to for DSN, however, as described in #2399 we have a temporary additional space that we can exploit to cache even more pieces, helping both with plotting performance and with retrieval from DSN.
First two commits here are doing some cleanup/refactoring, the last commit implements plot cache. Since logic of plot cache contained in
FarmerCacheis quite trivial, no newFarmerCache-specific tests were added at this time, butDiskPlotCacheitself has corresponding tests added to make sure lower-level component behaves as expected.I also tested manually locally with dev chain and will do extra tests with Gemini 3h farmer client before merging for extra confidence.
UPD: Tested, seems to work fine on 3h as well.
Resolves #2399
Code contributor checklist: