Remove extra boxing around Unpin requirement and fix fused future usage
#2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
requested review from
vedhavyas,
NingLin-P,
rg3l3dr and
shamil-gadelshin
as code owners
nazar-pc
changed the title
Unpin requirement and fixed fused future usageUnpin requirement and fix fused future usage
nazar-pc
force-pushed
the
remove-extra-boxing
branch
from
4a70e2d to
8440b5e
Compare
NingLin-P
previously approved these changes
Dec 11, 2023
# Conflicts: # crates/subspace-farmer/src/bin/subspace-farmer/commands/farm.rs
NingLin-P
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was removing extra boxing and noticed incorrect fused future usage in gossip code.
Fused futures are futures that have
.terminated()method on them for the purposes of not being called again inselect!(for example).By calling
.fuse()in a loop it does literally nothing since termination status is not preserved across loop iterations. Futures and streams should be fused before entering the loop. Not all uses were incorrect, but the issue was still there.Code contributor checklist: