Downloading/encoding concurrency #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or future reusability (the change is just a refactoring, no logic changes)
… future reusability (the change is just a refactoring, no logic changes)
nazar-pc
requested review from
rg3l3dr,
vedhavyas and
NingLin-P
as code owners
vedhavyas
approved these changes
Oct 30, 2023
rahulksnv
approved these changes
Oct 30, 2023
NingLin-P
reviewed
Oct 30, 2023
nazar-pc
commented
Oct 30, 2023
There was a problem hiding this comment.
Also, looks like we only concurrently downloading one sector, can it be more than one? or is that out of memory concern of the downloaded sector?
Memory usage will be excessive and generally we expect that downloading will be fast enough for this to not block encoding. With one farm you only download one sector ahead, but with multiple farms and --sector-downloading-concurrency increased from default value of 2, each farm can potentially download one sector ahead, but more than one per farm doesn't make a lot of sense and makes implementation tricky in terms of avoiding deadlocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #2027 by allowing next sector to be downloaded while the previous sector is being encoded.
All commits before the last one are just refactoring to enable necessary capabilities.
There are a few way to implement this, I decided to simply spawn background task and keep it in a variable to look into later.
As byproduct of refactoring
subspace-farmer-componentshas become more flexible, but at the same time previous simple API is still present for convenience.Code contributor checklist: