Staking: Max nominators for each operator #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedhavyas
requested review from
nazar-pc,
rg3l3dr and
NingLin-P
as code owners
vedhavyas
force-pushed
the
max_nominators
branch
from
967fefe to
2dc180d
Compare
NingLin-P
reviewed
Oct 16, 2023
Comment on lines
+291
to
+293
| /// The maximum number of nominators for given operator. | ||
| #[pallet::constant] | ||
| type MaxNominators: Get<u32>; |
There was a problem hiding this comment.
The limit is applied to every operator in every domain, perhaps we should move it to the OperatorConfig (similar to minimum_nominator_stake) such that:
- The limit is applied to a single operator and specified by the operator itself
- The limit can be updated through an extrinsic instead of a consensus runtime upgrade
There was a problem hiding this comment.
As discussed during the call, this is not what we are aiming to solve for stakewars and this approach would solve the operator deregistration issue with a lot of nominators
NingLin-P
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces MaxNominators parameter to limit nominators per Operators.
Since we cannot use
CountedStorageNmapto get the count with operatorId prefix, I introduced a new storage that tracks the nominator count for each operator. The count is tracked when there is a new nominator show intent to nominate or when a Nominator withdraws all the stake from an Operator.If MaxNominators are set to
0, which is a requirement for Stake wars, this will not allow any nominators for any operators and can be changed through a runtime upgrade.cc: @jfrank-summit
Code contributor checklist: