Support graceful and quick farmer shutdown in the middle of plotting process #2100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few reports about this and it annoyed me as well.
Essentially what was happening here is a blocking operation of plotting that outside
select
couldn't interrupt until sector plotting finishes, which in case of network issues can take a very long time.Here we do two things:
plot_sector
is async by itself, we race it with shutdown notificationplot_sector
we additionally yield to the async executor after each piece processed such that plotting can be interrupted in the middle of that compute-intensive process as well, not just during async piece downloadingNode that there are no yields when sector is ready and is being written to disk because this is both wasteful and shouldn't take a lot of time anyway.
Review with whitespace changes ignored, the diff is not that large.
Code contributor checklist: