Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #2099

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Remove unused dependencies #2099

merged 1 commit into from
Oct 12, 2023

Conversation

nazar-pc
Copy link
Member

This removes a lot of unused dependencies, especially in crates that have seen a lot of refactoring. I used cargo-machete to find unused crates (there were some false-negatives though).

Code contributor checklist:

Copy link
Member

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use unused-crate-dependencies I think to that gave me less false positives so far. Maybe we can add it at a later time 🤔 . It gave less false positives than machete before

@nazar-pc nazar-pc merged commit d0a1813 into main Oct 12, 2023
6 of 10 checks passed
@nazar-pc nazar-pc deleted the remove-unused-dependencies branch October 12, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants