Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce automatic Kademlia mode for subspace-networking. #2076

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Introduce automatic Kademlia mode for subspace-networking. #2076

merged 2 commits into from
Oct 10, 2023

Conversation

shamil-gadelshin
Copy link
Contributor

This PR introduces automatic Kademlia mode based on the Autonat probe results. It introduces KademliaMode support type in subpace-networking crate: Static option sets permanent Kademlia mode and Dynamic allows autonat to toggle it. Closes #1681

Changes

  • subspace-bootstrap-node is configured to Static(Server) Kademlia mode
  • subspace-node is configured to Static(Client) Kademlia mode
  • subspace-farmer is configured to Dynamic with initial Client mode.
  • the default configuration is set to Static(Client) Kademlia mode

Comments

  • pulsar should be configured to the same Kademlia mode as the farmer (FYI: @ParthDesai )

Code contributor checklist:

@shamil-gadelshin shamil-gadelshin added the networking Subspace networking (DSN) label Oct 9, 2023
@shamil-gadelshin shamil-gadelshin self-assigned this Oct 9, 2023
nazar-pc
nazar-pc previously approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking nits, makes sense otherwise

crates/subspace-networking/src/constructor.rs Outdated Show resolved Hide resolved
crates/subspace-networking/src/node_runner.rs Outdated Show resolved Hide resolved
@shamil-gadelshin shamil-gadelshin added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 396d55a Oct 10, 2023
10 checks passed
@shamil-gadelshin shamil-gadelshin deleted the automatic-kademlia-mode branch October 10, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc approved these changes

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr

Assignees

@shamil-gadelshin shamil-gadelshin

Labels
networking Subspace networking (DSN)
Projects
Subspace core (node, farmer, etc.)
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Kademlia routing table for DSN.
2 participants
@shamil-gadelshin @nazar-pc