addressing minor nits

crates/sp-domains-fraud-proof/src/tests.rs

@@ -12,7 +12,7 @@ use subspace_test_service::MockConsensusNode;
 use tempfile::TempDir;
 
 #[tokio::test(flavor = "multi_thread")]
-async fn runtime_instance_storage_assumptions_are_correct() {
+async fn storage_change_of_the_same_runtime_instance_should_perserved_cross_runtime_calls() {
     let directory = TempDir::new().expect("Must be able to create temporary directory");
 
     let mut builder = sc_cli::LoggerBuilder::new("");

domains/client/block-preprocessor/src/lib.rs

@@ -310,7 +310,6 @@ where
                 .is_ok();
 
             if !is_legal_tx {
-                // TODO: Generate a fraud proof for this invalid bundle
                 return Ok(BundleValidity::Invalid(InvalidBundleType::IllegalTx(
                     index as u32,
                 )));

domains/runtime/evm/src/lib.rs

@@ -913,10 +913,10 @@ impl_runtime_apis! {
                 return Err(InvalidTransaction::BadMandatory.into());
             }
 
-            let encoded = uxt.encode();
-            let encoded_len = encoded.len();
+            let encoded_len = uxt.encoded_size();
 
-            // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same) as that will add the side effect of SignedExtension in the storage buffer
+            // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same)
+            // as that will add the side effect of SignedExtension in the storage buffer
             // which would help to maintain context across multiple transaction validity check against same
             // runtime instance.
             match xt.signed {

domains/test/runtime/evm/src/lib.rs

@@ -900,10 +900,10 @@ impl_runtime_apis! {
                 return Err(InvalidTransaction::BadMandatory.into());
             }
 
-            let encoded = uxt.encode();
-            let encoded_len = encoded.len();
+            let encoded_len = uxt.encoded_size();
 
-            // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same) as that will add the side effect of SignedExtension in the storage buffer
+            // We invoke `pre_dispatch` in addition to `validate_transaction`(even though the validation is almost same)
+            // as that will add the side effect of SignedExtension in the storage buffer
             // which would help to maintain context across multiple transaction validity check against same
             // runtime instance.
             match xt.signed {