Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to enable Cmd+X/C/V on macOS #225

Closed
wants to merge 1 commit into from

Conversation

nazar-pc
Copy link
Member

Not yet sure if this will work, but it may fix #145 (or rather hack around it)

@nazar-pc
Copy link
Member Author

nazar-pc commented Jul 11, 2024

@abhi3700 or @DianaPertseva can you try https://github.com/subspace/space-acres/actions/runs/9901861110 (built from this PR) to see whether it helped or not?

@abhi3700
Copy link

abhi3700 commented Jul 11, 2024

@abhi3700 or @DianaPertseva can you try https://github.com/subspace/space-acres/actions/runs/9901861110 (built from this PR) to see whether it helped or not?

The issue is cmd key doesn't work, but ctrl does. Hence, ctrl+c/ctrl+x/ctrl+v works. Moreover, in the older macs, ctrl doesn't come. So, it's concerning there. But on the new ones, it's manageable.

It seems the upstream lib has kept the same key shortcut for mac as that on Win laptops.

@nazar-pc
Copy link
Member Author

nazar-pc commented Jul 11, 2024

@abhi3700 or @DianaPertseva can you try https://github.com/subspace/space-acres/actions/runs/9901861110 (built from this PR) to see whether it helped or not?

The issue is cmd key doesn't work, but ctrl does. Hence, ctrl+c/ctrl+x/ctrl+v works. Moreover, in the older macs, ctrl doesn't come. So, it's concerning there. But on the new ones, it's manageable.

It seems the upstream lib has kept the same key shortcut for mac as that on Win laptops.

I know that very well, but that is not what I'm asking here.
I'm asking you to check the liked test build that contains a potential workaround to see if it works with Cmd (see PR title).

@nazar-pc nazar-pc force-pushed the workaround-for-macos-keyboard branch from 0dfa613 to fa477a9 Compare July 12, 2024 03:16
@nazar-pc nazar-pc changed the base branch from main to fix-macos-build July 12, 2024 03:17
Base automatically changed from fix-macos-build to main July 12, 2024 03:34
@nazar-pc
Copy link
Member Author

Doesn't work unfortunately

@nazar-pc nazar-pc closed this Jul 12, 2024
@nazar-pc nazar-pc deleted the workaround-for-macos-keyboard branch July 12, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to paste the address into Config page
2 participants