Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example dependencies, update go version used in vulncheck scan #222

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

ewanharris
Copy link
Contributor

@ewanharris ewanharris commented Oct 12, 2023

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Update all dependencies in the examples that are flagging for GHSA-4374-p667-p6c8

🔧 Changes

📚 References

🔬 Testing

@ewanharris ewanharris requested a review from a team as a code owner October 12, 2023 09:47
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ce76d68) 94.78% compared to head (1e91364) 94.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files           7        7           
  Lines         307      307           
=======================================
  Hits          291      291           
  Misses         12       12           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris changed the title Update example dependencies to resolve Update example dependencies, update go version used in vulncheck scan Oct 12, 2023
@ewanharris
Copy link
Contributor Author

From the logs it appears the the govulncheck action is scanning against master due to the argument GITHUB_SHA=6bf126a726270b3621324771e97711b4426c57ea to the docker run command.

Going to try and see how we can override this

@ewanharris ewanharris enabled auto-merge (rebase) October 12, 2023 11:33
@ewanharris ewanharris merged commit 54e25fd into master Oct 12, 2023
7 checks passed
@ewanharris ewanharris deleted the chore/dep-updates branch October 12, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants