Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil checks to Versioned*BeaconBlock functions #111

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Add nil checks to Versioned*BeaconBlock functions #111

merged 3 commits into from
Feb 28, 2024

Conversation

jtraglia
Copy link
Contributor

This PR makes these changes:

  • Add a lot of missing nil checks in the Versioned*BeaconBlock files.
  • Change "no deneb block contents" to "no deneb block" which I think are copy/paste mistakes.
  • Fix a couple "denb" typos.
  • Handle DataVersionCapella case in BlobKZGCommitments function.
  • Remove v.Capella.Message.Body.ExecutionPayload check in Grafitti function.

There are two competing style for these nil checks. I used whichever was more prevalent in the file. Personally I like the split conditionals better, but it doesn't really matter. If you'd like me to use the same style, I'd be happy to make the change.

I'm made this PR without reaching out first because I'm under the assumption these will never actually be nil.

Copy link
Contributor

@mcdee mcdee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mcdee mcdee merged commit 8e9579c into attestantio:master Feb 28, 2024
1 of 2 checks passed
@jtraglia jtraglia deleted the versionedbeaconblock-nil-checks branch February 28, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants