Opt-in to debug endpoint usage in Validators
#100
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Beacon API spec says that the debug endpoints are:
For that reason, Prysm disables them by default, and since the
Validators
method leverages the debug endpoint to retrieve large validator sets, it's likely to fail in many setups.I believe that go-eth2-client should either check that these endpoints are available as part of client creation, or allow the user to opt-in to using them.
This PR implements the latter, since I suspect that requesting the state at every connection may be too heavy.
@mcdee If you think opting-in at the client-level is preferable to method-level, I wouldn't mind refactoring that.