Merge pull request #83 from xenowits/xenowits/fix-out-of-bounds

add out-of-bounds check

api/v1/validatorstate.go

@@ -96,6 +96,10 @@ func (v *ValidatorState) UnmarshalJSON(input []byte) error {
 }
 
 func (v ValidatorState) String() string {
+	if v < 0 || int(v) >= len(validatorStateStrings) {
+		return validatorStateStrings[0] // unknown
+	}
+
 	return validatorStateStrings[v]
 }
 

api/v1/validatorstate_test.go

@@ -288,3 +288,39 @@ func TestValidatorToState(t *testing.T) {
 		})
 	}
 }
+
+func TestString(t *testing.T) {
+	tests := []struct {
+		name     string
+		state    api.ValidatorState
+		expected string
+	}{
+		{
+			name:     "valid state",
+			state:    api.ValidatorStateActiveOngoing,
+			expected: "active_ongoing",
+		},
+		{
+			name:     "negative index",
+			state:    -1,
+			expected: "unknown",
+		},
+		{
+			name:     "edge bound index",
+			state:    10,
+			expected: "unknown",
+		},
+		{
+			name:     "high out of bound index",
+			state:    250,
+			expected: "unknown",
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			resp := test.state.String()
+			require.Equal(t, test.expected, resp)
+		})
+	}
+}