feat: add support for workspace folders #153
Conversation
aminya
force-pushed
the
workspaceFolders
branch
2 times, most recently
from
3781f83 to
b7e1d06
Compare
More information https://bit.ly/3uou37n
| @@ -60,6 +60,7 @@ export class ServerManager { | |||
| this._disposable.add(atom.project.onDidChangeFiles(this.projectFilesChanged.bind(this))) | |||
| } | |||
| } | |||
| this._isStarted = true | |||
There was a problem hiding this comment.
This was an irrelevant bug that I discovered here.
test/auto-languageclient.test.ts
Outdated
|
|
||
| async function afterEachCallback() { | ||
| serverManager.stopListening() | ||
| await serverManager.stopAllServers() |
There was a problem hiding this comment.
Looks like the tests are timing out at this line. When calling beforeEachCallback() at the end of the test before the afterEach is called it resets serverManager so there are no servers to stop.
There was a problem hiding this comment.
It was working with Sinon. I think this is related to the way jasmine mocks things.
Here is the old working commit before switching to jasmine.
764b050
There was a problem hiding this comment.
Does any of the Jasmine plugins modify clearTimeout and setTimeout functions? Does Jasmine support async functions inside afterEach and beforeEach?
I had the exact same problem in this PR.
This code was not timing out with Mocha, Sinon, Chai
There was a problem hiding this comment.
Does any of the Jasmine plugins modify clearTimeout and setTimeout functions?
Not unless jasmin.clock.install() is called.
Does Jasmine support async functions inside afterEach and beforeEach?
yes
This code was not timing out with Mocha, Sinon, Chai
This was most likely because of a difference in sinon. sinon.spy calls the function by default and spyOn stubs the function by default.
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Please do not squash the pull requests. I need to disable squash for this organization altogether so people don't do it by mistake |
|
Why not? squashing the commits of a PR makes the release notes much cleaner and includes the PR# so anyone can still see each commit. |
|
We should not sacrifice the version control for the sake of semantic release change log generation. If the issue is that, we should stop using automatically generated release notes. Related to this: |
Not true, this PR will still exist with the commits. And it will be easier to find since it will be in the release notes.
That seems like an error on their part. Like judging software by number of lines of code or “measuring aircraft building progress by weight” -- Bill Gates By the way, both of those arguments seem contrary to your arguments for combining dependency updates. I would much rather have those issues than have to write release notes manually for every release 🤣. |
Adds support for WorkspaceFolders as described here:
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#workspace_workspaceFolders