Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low state blazar #483

Open
wants to merge 55 commits into
base: master
Choose a base branch
from

Conversation

JulianHamo
Copy link
Collaborator

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes put link

If this is a new release, did you issue the corresponding schema in fink-client?

otherwise you'll break the livestream service!

What changes were proposed in this pull request?

How is the issue this PR is referenced against solved with this PR?

How was this patch tested?

JulianHamo and others added 30 commits December 18, 2024 12:08
Creation of the low state detection module file
Computation from ZTF data release 22
Description:
- 3FGL Name: Name of the source inthe 3FGL catalog
- ZTF Name: ZTF tag associated beforehand
- Array of Medians: Medians used to standardize the flux (np.nan if no median could be computed)
- Computed Threshold: 10th percentile of the standardized flux from the data release
- Observed Threshold: Measured flux during a previous redshift detrmination attempt
- Redshift: Redshift found during the previous spectroscopic observation
- Final Threshold: Minimum between the Computed Threshold and the Observed Threshold
Refont after utils.py creation
Edit documentation of low_state_
CTAO blazar comparison file (parquet)
Computation from ZTF data release 22
Description:
- 3FGL Name: Name of the source inthe 3FGL catalog
- ZTF Name: ZTF tag associated beforehand
- Array of Medians: Medians used to standardize the flux (np.nan if no median could be computed)
- Computed Threshold: 10th percentile of the standardized flux from the data release
- Observed Threshold: Measured flux during a previous redshift detrmination attempt
- Redshift: Redshift found during the previous spectroscopic observation
- Final Threshold: Minimum between the Computed Threshold and the Observed Threshold
Page setting
Update documentation
Fix name in standardized_flux_
Fix CTAO_PATH
Fix CTAO_PATH
Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JulianHamo -- you have no tests implemented yet?

@JulianHamo JulianHamo requested review from JulienPeloton and removed request for JulienPeloton January 10, 2025 13:15
Copy link
Member

@JulienPeloton JulienPeloton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JulianHamo ! I left two minor comments :-)

@@ -44,5 +44,6 @@ jobs:
- name: Run test suites
run: |
rm -f /tmp/forest_*.onnx
./run_tests.sh
./run_tests.sh --single_module fink_science/standardized_flux/processor.py
./run_tests.sh --single_module fink_science/blazar_low_state/processor.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you can remove this :-)

Array of ratios for:
Mean over threshold of the last but one alert
Mean over threshold of the last alert
Measurement over threshold of the last alert
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to specify default values of -1 in case of problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants