[Asteroid] Fink-FAT 1.0 extension #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): close #326
If this is a new release, did you issue the corresponding schema in fink-client?
otherwise you'll break the livestream service!
What changes were proposed in this pull request?
The extension of the asteroid science module can cross-match in the alert streams the incoming alerts with the trajectories found by fink-fat during the offline process. The new roid science module return now a nested structure containing the roid code, the same code as before (0, 1, 2 and 3) and 2 new codes. The 4 code is for alerts associated with a non-orbit trajectory predictor while the 5 code is for alerts associated with ephemerides prediction. If the code is 4, the nested structure contains the list of the trajectories and distance with which the alerts are associated within a radius given in the fink-fat configuration file. If the code is 5, it is the distance and the trajectory number of the closest ephemeride.
The extension needs the parquet file generated from fink-fat at the start of the job spark. If the files are not found, the module just skips the extension and returns to the pre-fink-fat behaviour.
How is the issue this PR is referenced against solved with this PR?
How was this patch tested?