Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fb algorithm, pnp-prior functionality, abstract classes, and kera… #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add fb algorithm, pnp-prior functionality, abstract classes, and kera… #12

wants to merge 2 commits into from

Conversation

CosmoMatt
Copy link

Overview
This PR includes quite a few bits and pieces that have been outstanding. Primarily it adds forward backward solver and enhances the codebase by supporting keras/tensorflow likelihood/priors.

Issues:

closes #5
closes #6

Additions:

  • adds a basic forward backward solver (this has been tested externally and can function with keras priors/gradients)
  • adds abstract classes to linear operators, proximal operators, ai operators, gradient operators.
  • adds forward backward 1d notebook
  • updates custom operator notebook to inherit the corresponding abstract class

@CosmoMatt CosmoMatt added the enhancement New feature or request label Mar 9, 2022
@CosmoMatt CosmoMatt requested a review from MatthijsMars March 9, 2022 20:10
@CosmoMatt CosmoMatt self-assigned this Mar 9, 2022
MatthijsMars
MatthijsMars approved these changes Aug 5, 2022
View reviewed changes
optimusprimal/primal_dual.py
"""Evaluates the Primal dual forward backward optimization

Args:

x_init (np.ndarray): First estimate solution
options (dict): Python dictionary of optimisation configuration parameters
g (Grad Class): Unconstrained data-fidelity class
f (Prox Class): Constrained data-fidelity class
p (Prox Class): Constrained data-fidelity class
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should keep order the same as arguments in function call

@tobias-liaudat
Copy link
Member

Hi @CosmoMatt and @MatthijsMars
I was checking out this PR, is there a reason it has not been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthijsMars MatthijsMars MatthijsMars approved these changes

Assignees

@CosmoMatt CosmoMatt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate any refactoring or architecture improvements Implement simple forward-backward solver
3 participants
@CosmoMatt @tobias-liaudat @MatthijsMars