Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit/minor changes #48

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Audit/minor changes #48

merged 3 commits into from
Oct 31, 2023

Conversation

JordyRo1
Copy link
Contributor

No description provided.

@github-actions
Copy link

Output from Compare Snapshot:

****IMPROVEMENTS****
pragma::tests::test_oracle::get_data_for_sources 17779934 --> 17779734 -0.00 %
pragma::tests::test_oracle::get_data_median 22719634 --> 22712634 -0.03 %
pragma::tests::test_oracle::get_data_median_for_sources 16578704 --> 16578604 -0.00 %
pragma::tests::test_oracle::get_data_median_for_sources_should_fail_if_wrong_sources 15933744 --> 15933644 -0.00 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_no_expiration_time_associated 16005854 --> 16005754 -0.00 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_data_types 15987444 --> 15987344 -0.00 %
pragma::tests::test_oracle::test_data_median_multi_should_fail_if_wrong_sources 16078524 --> 16078424 -0.00 %
pragma::tests::test_oracle::test_get_data 26125874 --> 26115774 -0.04 %
pragma::tests::test_oracle::test_get_data_median_multi 20805814 --> 20805214 -0.00 %
pragma::tests::test_oracle::test_get_data_with_USD_hop_should_fail_if_wrong_id 17258434 --> 17257034 -0.01 %
pragma::tests::test_oracle::test_get_data_with_usd_hop 20887314 --> 20882914 -0.02 %
pragma::tests::test_oracle::test_get_last_checkpoint_before 19663334 --> 19660734 -0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_timestamp_too_old 19179464 --> 19176864 -0.01 %
pragma::tests::test_oracle::test_get_last_checkpoint_before_should_fail_if_wrong_data_type 19179464 --> 19176864 -0.01 %
pragma::tests::test_oracle::test_set_checkpoint 19487954 --> 19485354 -0.01 %
pragma::tests::test_oracle::test_set_checkpoint_should_fail_if_wrong_data_type 16296104 --> 16295604 -0.00 %
pragma::tests::test_summary_stats::test_set_future_checkpoint 49030858 --> 49020458 -0.02 %
pragma::tests::test_summary_stats::test_summary_stats_mean_mean 43563462 --> 43550462 -0.03 %
pragma::tests::test_summary_stats::test_summary_stats_mean_median 43563462 --> 43550462 -0.03 %
pragma::tests::test_yield_curve::test_yield_curve_computation 16314392 --> 16313492 -0.01 %
pragma::tests::test_yield_curve::test_yield_curve_empty 5953610 --> 5952710 -0.02 %


****WORSENED****
None


Overall gas change: performance improvement, gas consumption-0.01 %

src/oracle/oracle.cairo Show resolved Hide resolved
@EvolveArt EvolveArt merged commit 8e1ff20 into main Oct 31, 2023
6 checks passed
@EvolveArt EvolveArt deleted the audit/minor-changes branch October 31, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants