Refactor into classes #217
Conversation
| getNumberChecks: GetNumberChecks | ||
| ) { | ||
| return { | ||
| ...mapNullableType('integer'), |
There was a problem hiding this comment.
I know this probably has been discussed and has tests, but is it correct that a BigInt should have an integer representation? BigInt is arbitrary-size, so 9238745923847592837459823745982734958273498572398457298347598237459872349857239847592837459827349587239845723984759823745987239458723984572983745982734958723498572398457 is a valid value, and it can't be represented as an integer type (even 64-bit) - should be a string IMO.
There was a problem hiding this comment.
Hmm you are correct. I don't remember discussing this, but it does have tests 😄. I think I am with you on this one and I would rather implement it. However I think I'd do this in a separate PR - just for future reference and ease of searching. I still think I'd release everything in a single release.
No description provided.