Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to graphql client repository #112

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Update links to graphql client repository #112

merged 4 commits into from
Nov 10, 2024

Conversation

th1988
Copy link
Contributor

@th1988 th1988 commented Nov 1, 2024

No description provided.

@th1988 th1988 force-pushed the update-links-to-graphql-client branch from ad26c50 to 7a44107 Compare November 1, 2024 20:10
@dangerpr-bot
Copy link

dangerpr-bot commented Nov 2, 2024 •
edited
Loading

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

yuki24
yuki24 approved these changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@yuki24 yuki24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about the CHANGELOG entry, but overall 👍

CHANGELOG.md Outdated
@@ -1,5 +1,6 @@
### (Next)
* Your contribution here.
* Update graphql-client github repository links in README - [@th1988]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this deserves a CHANGELOG entry, as there is no user-facing change in the code.

@dblock @ashkan18 Any thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but we do need to fix CI even if this is unrealated.

dblock
dblock requested changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the CHANGELOG line like the others, with link to PR and your name, thanks!

We do need to fix CI, I know it's not failing because of this change, but I'd prefer we don't merge anything before that. Maybe you can help?

@yuki24
Copy link
Collaborator

yuki24 commented Nov 3, 2024

@dblock The CI builds should be fixed by #113.

@dblock
Copy link
Collaborator

dblock commented Nov 4, 2024

Rebase this please?

@th1988 th1988 force-pushed the update-links-to-graphql-client branch from 7a44107 to bde6d9a Compare November 10, 2024 13:45
@th1988
Copy link
Contributor Author

th1988 commented Nov 10, 2024

Done @dblock 🚀

@dblock dblock merged commit c9f6f1a into ashkan18:master Nov 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@yuki24 yuki24 yuki24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@th1988 @dangerpr-bot @yuki24 @dblock