Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Стили для текста #47

Merged
merged 19 commits into from
Dec 3, 2023
Merged

Conversation

NikolayRyabcev
Copy link
Collaborator

  1. Добавлены шрифты.
  2. Жирный скачан дополнительно.
  3. Созданы стили для текста

2. Жирный скачан дополнительно.
3. Созданы стили для текста
@artwist-polyakov artwist-polyakov self-requested a review December 1, 2023 19:11
Copy link
Owner

@artwist-polyakov artwist-polyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Написал правки

app/src/main/res/values/dimen.xml Outdated Show resolved Hide resolved
app/src/main/res/values/style.xml Outdated Show resolved Hide resolved
app/src/main/res/values/style.xml Outdated Show resolved Hide resolved
app/src/main/res/values/style.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
app/src/main/res/values/style.xml Outdated Show resolved Hide resolved
app/src/main/res/values/style.xml Outdated Show resolved Hide resolved
app/src/main/res/values/themes.xml Show resolved Hide resolved
@GoetzDeBouville
Copy link
Collaborator

Предлагаю изменить название файла style на styles, так как у нас все values в множественном числе
image

@GoetzDeBouville GoetzDeBouville self-requested a review December 3, 2023 11:13
Copy link
Collaborator

@GoetzDeBouville GoetzDeBouville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Апрув, но если стили будут прописаны полностью в CamelCase это будет единообразием, я пишу стили полностью в CamelCase, коммент оставил.

app/src/main/res/values/style.xml Outdated Show resolved Hide resolved
app/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
app/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
@NikolayRyabcev NikolayRyabcev merged commit 2509e47 into develop Dec 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Создать стили для шрифтов // UI
4 participants