forked from artemiscloud/activemq-artemis-jolokia-api-server
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4] no login, token transferred to the broker #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lavocatt
force-pushed
the
poc-read-token
branch
from
December 12, 2024 16:47
8751649
to
2143902
Compare
lavocatt
added a commit
to lavocatt/activemq-artemis-self-provisioning-plugin
that referenced
this pull request
Dec 12, 2024
The new jolokia api server doesn't require to login to access its services but requires to have a bearer token passed onto every requests alongside the actual jolokia endpoint that is the target of the request. This PoC uses these new information and strips down the previous login phase we had. Since I haven't updated the readme yet, here are the information that you need to run this successfully: * first you need to login to you oc env * then go in the folder 'bridge-auth-https' and run ./setup.sh * in one terminal run `yarn start-tls` and in another one `yarn start-console-tls`, you need to be in tls mode for this to work for now, I'll debug later the http version. * then head out to the PoC PR for the jolokia api server and build & run it as usual arkmq-org/activemq-artemis-jolokia-api-server#3 Let me know how it goes!
lavocatt
force-pushed
the
poc-read-token
branch
2 times, most recently
from
December 16, 2024 16:39
3626508
to
3f4a8d2
Compare
lavocatt
added a commit
to lavocatt/activemq-artemis-self-provisioning-plugin
that referenced
this pull request
Dec 16, 2024
The new jolokia api server doesn't require to login to access its services but requires to have a bearer token passed onto every requests alongside the actual jolokia endpoint that is the target of the request. This PoC uses these new information and strips down the previous login phase we had. Since I haven't updated the readme yet, here are the information that you need to run this successfully: * first you need to login to you oc env * then go in the folder 'bridge-auth-https' and run ./setup.sh * in one terminal run `yarn start-tls` and in another one `yarn start-console-tls`, you need to be in tls mode for this to work for now, I'll debug later the http version. * then head out to the PoC PR for the jolokia api server and build & run it as usual arkmq-org/activemq-artemis-jolokia-api-server#3 Let me know how it goes!
lavocatt
force-pushed
the
poc-read-token
branch
from
December 18, 2024 15:10
3f4a8d2
to
34f0652
Compare
lavocatt
changed the title
WIP: no login, token transferred to the broker
[#4] no login, token transferred to the broker
Dec 18, 2024
lavocatt
force-pushed
the
poc-read-token
branch
from
December 18, 2024 16:21
34f0652
to
43e0075
Compare
lavocatt
force-pushed
the
poc-read-token
branch
2 times, most recently
from
December 18, 2024 17:09
91c3c94
to
30406c5
Compare
The jolokia api server is now in a mode where it doesn't perform any login verification and just forward the Bearer token to the broker. The user needs to provide a targetEndpoint and a Bearer token on every request except api-info. Based on @gaohoward's work there: artemiscloud#23
lavocatt
force-pushed
the
poc-read-token
branch
from
December 19, 2024 08:58
30406c5
to
142240d
Compare
Msarawan
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jolokia api server is now in a mode where it doesn't perform
any login verification and just forward the Bearer token to the broker.
The user needs to provide a targetEndpoint and a Bearer token on every
request except api-info.