Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#105] Drainer pod uses un-resolvable hostname for it's cluster connection #106

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

gaohoward
Copy link
Collaborator

@gaohoward gaohoward commented Jul 10, 2024

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <yourname@example.com> - use git commit -s

@gaohoward gaohoward changed the title [#105] Drainer pod uses un-resolvable hostname for it's cluster conne… [#105] Drainer pod uses un-resolvable hostname for it's cluster connection Jul 10, 2024
@gaohoward gaohoward requested review from brusdev and gtully July 10, 2024 12:27
@gaohoward gaohoward linked an issue Jul 10, 2024 that may be closed by this pull request
@brusdev
Copy link
Contributor

brusdev commented Jul 10, 2024

An alternative solution to the IP address is to pass the full hostname as the Operator does for jolokia client, see https://github.com/artemiscloud/activemq-artemis-operator/blob/main/pkg/utils/jolokia_client/jolokia_client.go#L75

@gaohoward gaohoward force-pushed the e_fix_scaledown_retry branch from 41c9d3d to be0edee Compare July 11, 2024 08:20
@gaohoward
Copy link
Collaborator Author

An alternative solution to the IP address is to pass the full hostname as the Operator does for jolokia client, see https://github.com/artemiscloud/activemq-artemis-operator/blob/main/pkg/utils/jolokia_client/jolokia_client.go#L75

That may not work. The problem is that the drainer pod is a standalone pod and the DNS record for the pod may not be even generated (because it is not part of the headless service any more). To get a valid resolvable record some more configurations need to be added for this pod. So I think the IP address solution is the simple one to go.

@gaohoward gaohoward force-pushed the e_fix_scaledown_retry branch from be0edee to f9179b0 Compare July 11, 2024 08:27
@gaohoward gaohoward requested a review from brusdev July 11, 2024 08:28
modules/activemq-artemis-launch/added/drain.sh Outdated Show resolved Hide resolved
@gaohoward gaohoward force-pushed the e_fix_scaledown_retry branch from f9179b0 to 6f85ec5 Compare July 11, 2024 12:18
@gaohoward gaohoward requested a review from brusdev July 11, 2024 12:18
@gaohoward gaohoward merged commit 6b675e0 into arkmq-org:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drainer pod uses un-resolvable hostname for it's cluster connection
3 participants