Move optimizer_enable_query_parameter GUC to Orca extension #1172
+58
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move optimizer_enable_query_parameter GUC to Orca extension
Problem:
'optimizer_enable_query_parameter' GUC is a setting that affects Orca behavior,
so we would like it to reside in Orca. But this GUC was also referenced by the
core (in 'choose_custom_plan()'). It prevented moving of the GUC to the
extension.
Fix:
In 'choose_custom_plan()' the GUC was used to make a decision whether to use
custom or generic plan in plan cache manager. In general, this decision can be
affected by different parameters, and a generic external planner should be able
to have control over this decision. Thus, this patch:
to the extension side.
extension previously.