Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: authz amino converters #126

Merged
merged 5 commits into from
Dec 11, 2024
Merged

feat: authz amino converters #126

merged 5 commits into from
Dec 11, 2024

Conversation

eliasmpw
Copy link
Contributor

No description provided.

@eliasmpw eliasmpw requested review from macku99 and pyncz December 11, 2024 13:02
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codacy-production bot commented Dec 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 95.83%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3a4d4ba) 1390 1327 95.47%
Head commit (a1725a2) 1525 (+135) 1456 (+129) 95.48% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#126) 144 138 95.83%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Member

@pyncz pyncz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix linting for tx.ts file, it's quite challenging to review rn because of the reported checks D:

packages/arch3-core/src/modules/authz/tx.ts Outdated Show resolved Hide resolved
@eliasmpw eliasmpw requested a review from pyncz December 11, 2024 17:48
@eliasmpw eliasmpw requested a review from pyncz December 11, 2024 18:39
@eliasmpw eliasmpw merged commit 803dcda into main Dec 11, 2024
8 of 9 checks passed
@eliasmpw eliasmpw deleted the feat/authz-amino-converters branch December 11, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants