Fix #2250 by using a consistent naming strategy. #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Helveg does this fix your troubles? |
boeschf
approved these changes
Jan 18, 2024
Comment on lines
+249
to
+250
| fs::path fn = outdir / (mod + "_cpu"); | ||
| fn.replace_extension(".cpp"); |
There was a problem hiding this comment.
Suggested change
| fs::path fn = outdir / (mod + "_cpu"); | |
| fn.replace_extension(".cpp"); | |
| fs::path fn = outdir / (mod + "_cpu.cpp"); |
There was a problem hiding this comment.
I kind of like the symmetry. Yes, it's redundant, but I like it anyway ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
module_namestring to name files consistently.Fixes #2250