Add water quality data to site model and use it to power site filter

[yaodingyd]

fix #1026
/claim #1026

Add waterQuality to site model that would include list of water quality metrics.

The logics to determine water quality metrics is from

aqualink-app/packages/website/src/common/SiteDetails/index.tsx

Lines 157 to 174 in 56dbb9c

	const combinedArray = [...forecastData, ...latestData];
	const parsedData = parseLatestData(combinedArray);
	const hasSpotter = Boolean(parsedData.bottomTemperature);
	const hasSonde =
	sondeMetrics.filter((x) => Boolean(parsedData[x])).length >=
	MINIMUM_SONDE_METRICS_TO_SHOW_CARD;
	const hasHUI =
	latestData.some((x) => x.source === 'hui') ||
	sourceWithinDataRangeInterval(
	acceptHUIInterval,
	'hui',
	timeSeriesRange,
	);
	setHasSondeData(hasSonde);
	setHasSpotterData(hasSpotter);
	setHasHUIData(hasHUI);

which looks at LatestData entity (and forecast data, omitted by now) and check if they have hui source or enough sonde metrics.

If this is the correct direction, I can work on a follow up to remove the checks in frontend and consolidate to the backend, so we have single source of truth. This also avoid multiple data fetching to get water quality data

[pullrequest]

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:

• Comments posted to any areas of potential concern or improvement.
• Detailed feedback or actions needed to resolve issues that are found.
• Turnaround times vary, but we aim to be swift.

---

@yaodingyd you can click here to see the review status or cancel the code review job.

[pullrequest]

PullRequest Breakdown

Reviewable lines of change

+ 69
- 1

84% TypeScript
16% Jest Snapshot (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

[pullrequest]

This PR looks quite good for adding water quality data to the site. I only had minor comments as feedback below.

Nice work!

Ryan

---

Reviewed with ❤️ by PullRequest

[pullrequest]

This probably warrants some discussion, especially disabling it for the entire file.

I would guess those rules are there for a reason, so it's probably worth having a discussion with the maintainers about what the intent is for keeping them.

Generally a pattern I follow in these situations is to:

• Disable the rule for an individual line
• Add a justification with a username, date, and explanation of why there's no better solution to this at the moment.

This helps to ensure that even if this code base is OK bending the rules on some of these, it's clearly documented when and why that's OK, rather than just disabling it for the entire file with no notes.

Additionally, this could lead to discussion about whether or not the rule is actually needed in this project.

🔸 Best Practices (Important)

Ryan

[pullrequest]

PullRequest reviewed the updates made to #1049 up until the latest commit (af203c4). No further issues were found.

Reviewed by:

Ryan

[pullrequest]

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

[yaodingyd]

Am I missing a config or something? I opened a another PR #1073 with literally a comment change but still failing API CIs. the error doesn't make much sense to me, as I'm not even touching any env files

    config error - missing env.BACKEND_BASE_URL

[ericboucher]

I think it might be due to GitHub protections around variables for external contributors... It's super annoying. Let me add you to the repo if that's ok with you?

[yaodingyd]

I think PR has to be opened in this repo (not in forks) for API CI to pass, like #1075. I'll recreate this PR

[yaodingyd]

recreated as #1076