[fix] fix the problem of vertial ultra vires when only open the conso… #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornado-ssy
force-pushed
the
patch-2.2.0-0627
branch
from
d827f18 to
1ff9f77
Compare
humingcheng
approved these changes
Jun 27, 2024
server/config/config.go
Outdated
| @@ -185,7 +185,8 @@ func loadServerConfig() ServerConfig { | |||
|
|
|||
| SchemaDisable: GetBool("registry.schema.disable", false, WithENV("SCHEMA_DISABLE")), | |||
|
|
|||
| EnableRBAC: GetBool("rbac.enable", false, WithStandby("rbac_enabled")), | |||
| EnableRBAC: GetBool("rbac.enable", false, WithStandby("rbac_enabled")), | |||
| AllowMissToken: GetBool("rbac.allowMissToken", true, WithStandby("rbac_allow_missToken")), | |||
There was a problem hiding this comment.
默认应当不允许不传token，默认值应当为false
humingcheng
approved these changes
Jun 27, 2024
tornado-ssy
added a commit
to tornado-ssy/servicecomb-service-center
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le auth
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.go buildgo testgo fmtgo vetto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.