[#4485] Adjusting the address isolation logic of the servicecomb engine registration and config center #4486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b engine registration and configuration center
liubao68
reviewed
Sep 2, 2024
Comment on lines
66
to
67
| // if address in same zone will be true; others will be false. | ||
| private final Map<String, Boolean> addressCategory = new HashMap<>(); | ||
| private final Set<String> addressCategory = new HashSet<>(); |
There was a problem hiding this comment.
code comments not correct.
liubao68
reviewed
Sep 2, 2024
| private List<String> addresses = new ArrayList<>(); | ||
| private volatile List<String> addresses = new ArrayList<>(); | ||
|
|
||
| private final List<String> default_isolation_address = new ArrayList<>(); |
liubao68
reviewed
Sep 2, 2024
| this.defaultAddress.addAll(addresses); | ||
| this.index = addresses.size() > 0 ? random.nextInt(addresses.size()) : 0; | ||
| this.addressCategory.addAll(addresses); | ||
| this.index = !addresses.isEmpty() ? random.nextInt(addresses.size()) : 0; |
There was a problem hiding this comment.
addresses and addressCategory may have different size and cause IndexOutOfBounds
liubao68
reviewed
Sep 2, 2024
| if (!addresses.isEmpty()) { | ||
| return getCurrentAddress(addresses); | ||
| } | ||
| return getInitAddress(); | ||
| LOGGER.warn("all address is isolation, please check server status."); |
There was a problem hiding this comment.
All addresses are isolated.
liubao68
reviewed
Sep 2, 2024
| } | ||
| LOGGER.warn("all auto discovery address is isolation, please check server status."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.