Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3727]enhance metrics to reflect current process flow #4012

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Nov 6, 2023

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #4012 (999b578) into master (ec57988) will increase coverage by 0.47%.
The diff coverage is 44.52%.

❗ Current head 999b578 differs from pull request most recent head c0ab025. Consider uploading reports for the commit c0ab025 to get more accurate results

@@             Coverage Diff              @@
##             master    #4012      +/-   ##
============================================
+ Coverage     43.88%   44.35%   +0.47%     
- Complexity     5378     5417      +39     
============================================
  Files          1389     1388       -1     
  Lines         34383    34311      -72     
  Branches       3351     3359       +8     
============================================
+ Hits          15089    15219     +130     
+ Misses        18064    17863     -201     
+ Partials       1230     1229       -1     
Files Coverage Δ
.../servicecomb/core/event/InvocationFinishEvent.java 100.00% <ø> (+25.00%) ⬆️
...apache/servicecomb/core/filter/AbstractFilter.java 71.42% <100.00%> (+7.79%) ⬆️
...ava/org/apache/servicecomb/core/filter/Filter.java 20.00% <ø> (ø)
...org/apache/servicecomb/core/filter/FilterNode.java 91.66% <100.00%> (+0.75%) ⬆️
...comb/core/filter/impl/ProviderOperationFilter.java 13.63% <ø> (+0.59%) ⬆️
...core/invocation/InvocationTimeoutBootListener.java 66.66% <ø> (-2.57%) ⬇️
...omb/core/invocation/InvocationTimeoutStrategy.java 35.29% <ø> (-6.82%) ⬇️
...rvicecomb/core/provider/consumer/InvokerUtils.java 68.91% <100.00%> (+0.42%) ⬆️
...core/meter/invocation/AbstractInvocationMeter.java 96.29% <100.00%> (+32.65%) ⬆️
...core/meter/invocation/ConsumerInvocationMeter.java 100.00% <100.00%> (+32.14%) ⬆️
... and 27 more

... and 26 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@liubao68 liubao68 merged commit 2dd9757 into apache:master Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants