Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2813]normalize health and metrics endpoint #3997

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #3997 (e6882f5) into master (429a57a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e6882f5 differs from pull request most recent head 34bab47. Consider uploading reports for the commit 34bab47 to get more accurate results

@@            Coverage Diff            @@
##             master    #3997   +/-   ##
=========================================
  Coverage     43.67%   43.67%           
+ Complexity     5374     5366    -8     
=========================================
  Files          1394     1393    -1     
  Lines         34402    34385   -17     
  Branches       3353     3353           
=========================================
- Hits          15025    15018    -7     
+ Misses        18161    18144   -17     
- Partials       1216     1223    +7     
Files Coverage Δ
...he/servicecomb/demo/springmvc/SpringmvcClient.java 82.35% <100.00%> (ø)
...b/foundation/metrics/health/HealthCheckResult.java 0.00% <ø> (ø)
.../servicecomb/metrics/core/MetricsBootListener.java 88.88% <ø> (+9.94%) ⬆️
...icecomb/metrics/core/MetricsCoreConfiguration.java 100.00% <100.00%> (ø)
...solution/basic/integration/HealthEndpointImpl.java 12.50% <100.00%> (ø)
...solution/basic/integration/HealthInstancePing.java 50.00% <ø> (ø)
...ion/basic/integration/InstanceOpenAPIRegistry.java 57.50% <ø> (ø)
...on/basic/integration/IntegrationConfiguration.java 100.00% <100.00%> (ø)
...tion/basic/integration/ManagementEndpointImpl.java 25.00% <ø> (ø)
...olution/basic/integration/MetricsEndpointImpl.java 11.11% <100.00%> (ø)

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 964115c into apache:master Oct 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants