Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2813]Nacos implementation not properly handle instance change #3982

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3982 (0cc7560) into master (ed60267) will increase coverage by 0.00%.
The diff coverage is 63.63%.

❗ Current head 0cc7560 differs from pull request most recent head ee0381c. Consider uploading reports for the commit ee0381c to get more accurate results

@@            Coverage Diff            @@
##             master    #3982   +/-   ##
=========================================
  Coverage     43.99%   44.00%           
+ Complexity     5329     5328    -1     
=========================================
  Files          1392     1392           
  Lines         34041    34055   +14     
  Branches       3331     3331           
=========================================
+ Hits          14978    14986    +8     
- Misses        17874    17884   +10     
+ Partials       1189     1185    -4     
Files Coverage Δ
...cecomb/common/rest/locator/ServicePathManager.java 58.00% <ø> (-3.82%) ⬇️
...omb/config/nacos/NacosDynamicPropertiesSource.java 0.00% <ø> (ø)
...rvicecomb/foundation/metrics/MetricsBootstrap.java 90.32% <100.00%> (+6.98%) ⬆️
...omb/foundation/metrics/MetricsBootstrapConfig.java 78.57% <ø> (ø)
.../registry/discovery/StatefulDiscoveryInstance.java 81.13% <100.00%> (+4.20%) ⬆️
...ecomb/foundation/common/utils/SPIServiceUtils.java 70.17% <100.00%> (-1.26%) ⬇️
.../apache/servicecomb/registry/DiscoveryManager.java 69.51% <56.75%> (-1.83%) ⬇️

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 4a1da76 into apache:master Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants