Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2813]refactoring configuration extension because can not using C… #3976

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

liubao68
Copy link
Contributor

…onfigurationProperties before configuration setup

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…onfigurationProperties before configuration setup
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@793b1c1). Click here to learn what that means.
The diff coverage is 60.57%.

❗ Current head 42e61bf differs from pull request most recent head c617c2e. Consider uploading reports for the commit c617c2e to get more accurate results

@@            Coverage Diff            @@
##             master    #3976   +/-   ##
=========================================
  Coverage          ?   43.76%           
  Complexity        ?     5305           
=========================================
  Files             ?     1391           
  Lines             ?    34023           
  Branches          ?     3336           
=========================================
  Hits              ?    14889           
  Misses            ?    17944           
  Partials          ?     1190           
Files Coverage Δ
...in/java/org/apache/servicecomb/core/SCBEngine.java 75.64% <100.00%> (ø)
...servicecomb/core/ServiceCombCoreConfiguration.java 100.00% <100.00%> (ø)
...servicecomb/core/invocation/InvocationFactory.java 76.47% <100.00%> (ø)
...b/core/provider/producer/ProducerBootListener.java 50.00% <100.00%> (ø)
...pache/servicecomb/demo/edge/consumer/Consumer.java 89.04% <100.00%> (ø)
.../demo/edge/consumer/EdgeServiceGovernanceTest.java 86.76% <100.00%> (ø)
...ringmvc/client/CodeFirstRestTemplateSpringmvc.java 98.43% <100.00%> (ø)
...ervicecomb/demo/springmvc/client/TestResponse.java 96.62% <100.00%> (ø)
...servicecomb/config/apollo/ApolloConfiguration.java 0.00% <ø> (ø)
...rvicecomb/config/cc/ConfigCenterConfiguration.java 100.00% <ø> (ø)
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 06b2b5f into apache:master Oct 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants