[ISSUE #9111] Support export broker RocksDB Config to json file #9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9114 +/- ##
=============================================
- Coverage 47.94% 47.91% -0.04%
- Complexity 12037 12047 +10
=============================================
Files 1320 1321 +1
Lines 92827 92970 +143
Branches 11897 11912 +15
=============================================
+ Hits 44507 44546 +39
- Misses 42809 42915 +106
+ Partials 5511 5509 -2 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
Jan 9, 2025
| Option clusterOption = new Option("c", "cluster", true, | ||
| "Cluster name. If nameserverAddr and clusterName are provided, will ignore [-p, -t, -e] args"); | ||
| options.addOption(clusterOption); | ||
|
|
There was a problem hiding this comment.
Are there situations where it is necessary to use the -b parameter to specify an individual broker?
|
I think we can remove the ExportMetadataInRocksDBCommand, as this command duplicates the functionality of RocksDBConfigToJsonCommand command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9111
Brief Description
How Did You Test This Change?