Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 9072]Fix the permission check for retry topic to get topic route. #9073

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

dingshuangxi888
Copy link
Contributor

Which Issue(s) This PR Fixes

When a client fails to consume multiple times, a message is sent to the retry topic. If ACL 2.0 is used, querying the routing of the retry topic may result in a permission denied issue.

Fixes #9072

Brief Description

When obtaining the routing for the retry topic, authentication is performed according to the Group's permissions, and there is no need to separately authorize the retry topic.

How Did You Test This Change?

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.84%. Comparing base (16b6e53) to head (7443b37).

Files with missing lines Patch % Lines
...on/builder/DefaultAuthorizationContextBuilder.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9073      +/-   ##
=============================================
- Coverage      47.84%   47.84%   -0.01%     
  Complexity     11865    11865              
=============================================
  Files           1312     1312              
  Lines          91740    91743       +3     
  Branches       11752    11753       +1     
=============================================
  Hits           43890    43890              
- Misses         42427    42433       +6     
+ Partials        5423     5420       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lollipopjin lollipopjin merged commit 91fdc35 into apache:develop Dec 20, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the permission check for retry topic to get topic route.
4 participants