Fix BasePolarisAuthenticator to throw service exception during persistence errors #707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases when the persistence store in unavailable or experiencing errors, the authenticator catches exceptions and causes the service to incorrectly return
401
. These exceptions are almost never retried by upstream clients or reverse proxies, so intermittent failures will cause clients to simply shut down. This correctly throws ServiceFailureExceptions in these cases and adds a unit test specifically for theBasePolarisAuthenticator