Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs/build command with --rm option #210

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 26, 2024

Description

Add docs/build command so that we can execute the command more easily.

Type of change

Please delete options that are not relevant.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code

docs/build Outdated

set -eux

docker run -p 8080:80 -v ${PWD}:/spec docker.io/redocly/cli join spec/docs.yaml spec/polaris-management-service.yml spec/rest-catalog-open-api.yaml -o spec/index.yaml --prefix-components-with-info-prop title
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we moving this, mind adding a --rm to the docker options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, added --rm option.

@ebyhr ebyhr changed the title Add docs/build command Add docs/build command with --rm option Aug 26, 2024
Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@snazy snazy enabled auto-merge (squash) August 26, 2024 11:03
@snazy snazy merged commit 0316c32 into apache:main Aug 26, 2024
3 checks passed
@ebyhr ebyhr deleted the ebi/docs-command branch August 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants