Simplify Java streams usage

apache · Aug 26, 2024 · 63940b2 · 63940b2
1 parent 7b4aa0b
commit 63940b2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/...ice/src/test/java/org/apache/polaris/service/admin/PolarisServiceImplIntegrationTest.java b/...ice/src/test/java/org/apache/polaris/service/admin/PolarisServiceImplIntegrationTest.java
@@ -107,7 +107,9 @@ public static void setup(PolarisConnectionExtension.PolarisToken adminToken) {
   @AfterEach
   public void tearDown() {
     try (Response response = newRequest("http://localhost:%d/api/management/v1/catalogs").get()) {
-      response.readEntity(Catalogs.class).getCatalogs().stream()
+      response
+          .readEntity(Catalogs.class)
+          .getCatalogs()
           .forEach(
               catalog ->
                   newRequest("http://localhost:%d/api/management/v1/catalogs/" + catalog.getName())

diff --git a/polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java b/polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java
@@ -34,7 +34,6 @@
 import java.util.Set;
 import java.util.UUID;
 import java.util.function.Supplier;
-import java.util.stream.Collectors;
 import org.apache.commons.lang3.NotImplementedException;
 import org.apache.iceberg.BaseTable;
 import org.apache.iceberg.CatalogProperties;
@@ -1143,12 +1142,7 @@ private TableMetadata createSampleTableMetadata(String tableLocation) {
   private void createNonExistingNamespaces(Namespace namespace) {
     // Pre-create namespaces if they don't exist
     for (int i = 1; i <= namespace.length(); i++) {
-      Namespace nsLevel =
-          Namespace.of(
-              Arrays.stream(namespace.levels())
-                  .limit(i)
-                  .collect(Collectors.toList())
-                  .toArray(String[]::new));
+      Namespace nsLevel = Namespace.of(Arrays.copyOf(namespace.levels(), i));
       if (!catalog.namespaceExists(nsLevel)) {
         catalog.createNamespace(nsLevel);
       }

diff --git a/...e/src/test/java/org/apache/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java b/...e/src/test/java/org/apache/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
@@ -480,7 +480,7 @@ public void testListGrantsOnCatalogObjectsToCatalogRoles() {
             tableGrant2,
             viewGrant1,
             viewGrant2);
-    role1Grants.stream().forEach(grant -> addGrant("catalogrole1", grant));
+    role1Grants.forEach(grant -> addGrant("catalogrole1", grant));
     List<GrantResource> role2Grants =
         List.of(
             catalogGrant1,
@@ -491,7 +491,7 @@ public void testListGrantsOnCatalogObjectsToCatalogRoles() {
             tableGrant3,
             viewGrant1,
             viewGrant3);
-    role2Grants.stream().forEach(grant -> addGrant("catalogrole2", grant));
+    role2Grants.forEach(grant -> addGrant("catalogrole2", grant));
 
     // List grants for catalogrole1
     try (Response response =