Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts to (semi)automate release steps #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Treora
Copy link
Contributor

@Treora Treora commented Oct 12, 2021

These are roughly the commands from our Creating a Release and Testing a Source Release wiki pages, with the idea to make these procedures easier for a next release.

@tilgovi & @BigBlueHat would you like to improve these scripts, or take another approach to it? Consider it just a draft; feel free to modify substantially or ignore this attempt altogether.

@tilgovi
Copy link
Contributor

tilgovi commented Oct 17, 2021

This is a great start! I'll check out the branch locally, see if there are any tweaks to make, and maybe try to push up changes to make the verify command interactive. How does that sound?

@Treora
Copy link
Contributor Author

Treora commented Nov 7, 2021

This is a great start! I'll check out the branch locally, see if there are any tweaks to make, and maybe try to push up changes to make the verify command interactive. How does that sound?

Sounds good! Sorry for my lack of reply before. As said, feel free to build on this or deviate from it.

Copy link
Contributor

@tilgovi tilgovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny questions, but feel free to merge! Thanks, @Treora.

@@ -0,0 +1,52 @@
set -e

#VERSION=0.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove these comments.

# Expects Apache RAT 0.13 jar to be present in home directory
# wget https://dlcdn.apache.org/creadur/apache-rat-0.13/apache-rat-0.13-bin.zip
# unzip apache-rat-0.13-bin.zip
java -jar ~/apache-rat-0.13.jar -E .ratignore -d .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should just download rat here?

@Treora
Copy link
Contributor Author

Treora commented Mar 31, 2022

I added a commit that downloads RAT, removes comments, removes the sleep pauses too. But I get an error when running this, which looks unrelated to the current change:

$ VERSION=0.2.0 RC=1 ../incubator-annotator/scripts/obtain-rc.sh
…
$ VERSION=0.2.0 RC=1 ../incubator-annotator/scripts/verify-rc.sh
…
tar: apache-annotator-0.2.0-incubating/.git/objects/pack/pack-4e188f5a157612fce8b35a7c799ff1c71b2af004.idx: Cannot open: Permission denied
tar: apache-annotator-0.2.0-incubating/.git/objects/pack/pack-4e188f5a157612fce8b35a7c799ff1c71b2af004.pack: Cannot open: Permission denied

Could you perhaps check if it works for you, @tilgovi (or anyone)?

@tilgovi
Copy link
Contributor

tilgovi commented Apr 20, 2022

@Treora I would be fine to drop the RAT steps. It feels strange to download a jar and leave it on the machine. Unless we download it to the current directory.

@tilgovi
Copy link
Contributor

tilgovi commented Apr 20, 2022

As for the error, something must be wrong with the permissions on the git directory that gets created.

I am thinking that initializing a git repository inside the archive is a bit surprising. It definitely looks wrong to have a .git directory. I can make a PR to use git archive instead of git clone. It will just make the steps to compare the archive against the tag a little bit different.

@reckart reckart added this to the 0.3.0 milestone Oct 1, 2023
@reckart reckart added the ⚙️ Refactoring Improvement for development or maintainability label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Refactoring Improvement for development or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants