IGNITE-24163 Optimize EventLog #5004
Open
+259
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PakhomovAlexander
force-pushed
the
IGNITE-24163
branch
2 times, most recently
from
43c78cc to
0adaae8
Compare
modules/eventlog/src/main/java/org/apache/ignite/internal/eventlog/api/EventLog.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Jan 7, 2025
...rc/main/java/org/apache/ignite/internal/eventlog/impl/ConfigurationBasedChannelRegistry.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Jan 7, 2025
| guard.readLock().unlock(); | ||
| } | ||
| Set<EventChannel> result = typeCache.get().get(igniteEventType); | ||
| return result == null ? Set.of() : new HashSet<>(result); |
There was a problem hiding this comment.
Why? I return the collection outside and I do not want anybody to modify it.
Benchmark results against baseline (single if statement).
|
PakhomovAlexander
force-pushed
the
IGNITE-24163
branch
2 times, most recently
from
e48737e to
9ac4c34
Compare
* Get rid of unnecessary locking in `log` method * Add one more "lazy" log method to the interface
PakhomovAlexander
force-pushed
the
IGNITE-24163
branch
from
9ac4c34 to
7fbdc5b
Compare
|
@AMashenkov applied most of your suggestions. Also, added a couple of additional optimizations (return null instead of empty collection) wich have improved the performance of the critical path. The PR now is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logmethodisEmpty()call was contributing about 20% execution time toEventLog.logmethod)https://issues.apache.org/jira/browse/IGNITE-24163