Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19090. Use protobuf-java 3.23.4 #34

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Feb 26, 2024

See https://issues.apache.org/jira/browse/HADOOP-19090 - this is still WIP and needs testing

@pjfanning pjfanning marked this pull request as draft February 26, 2024 16:28
@pjfanning pjfanning marked this pull request as ready for review February 27, 2024 13:13
@pjfanning
Copy link
Contributor Author

@steveloughran do you have the permissions to rerun the CI build? - I think it was just a download issue

This update looks promising - see apache/hadoop#6593 (comment)

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveloughran steveloughran merged commit 408321a into apache:trunk Feb 28, 2024
3 checks passed
@steveloughran
Copy link
Contributor

merged. Then had to do a quick followup patch (same JIRA) to update the LICENSE-binary file. Thought that was easier than doing a revert, cherrypick with the license patch etc.

@pjfanning pjfanning deleted the HADOOP-19090 branch February 28, 2024 13:26
@steveloughran
Copy link
Contributor

actually, just reset the branch to HEAD^ to lose the license change; force pushed it (!). need to update site docs too, see. will do a proper PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants