Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19063. [thirdparty] Fix the docker image setuptools-scm && lazy-object-proxy. #30

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Feb 2, 2024

Jira

JIRA: HADOOP-19063. [thirdparty] Fix the docker image setuptools-scm && lazy-object-proxy.

Describe

When compiling the docker-image, I found that the Dockerfile failed to execute pip install setuptools-scm && pip install lazy-object-proxy. This is because setuptools-scm && lazy-object-proxy has been upgraded many times and currently no longer supports python2.7.

I have consulted the release history lists of setuptools-scm and lazy-object-proxy, and I have found two versions that can be successfully installed. I have tested these two versions and confirmed that they can be installed properly and function correctly.

setuptools-scm==5.0.2
lazy-object-proxy==1.5.0

Copy link

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@slfan1989 slfan1989 merged commit 68d872f into apache:trunk Feb 4, 2024
3 checks passed
@slfan1989
Copy link
Contributor Author

@Hexiaoqiao @steveloughran Thanks for reviewing the code! merged into trunk.

slfan1989 added a commit that referenced this pull request Feb 4, 2024
…y-object-proxy (#30) Contributed by Shilun Fan

Reviewed-by: Steve Loughran <stevel@cloudera.com>
Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
slfan1989 added a commit that referenced this pull request Feb 4, 2024
…y-object-proxy (#30) Contributed by Shilun Fan

Reviewed-by: Steve Loughran <stevel@cloudera.com>
Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants