[#6300] fix(workflow): add an flag to control whether update docker latest tag. #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
jerryshao
reviewed
Jan 17, 2025
.github/workflows/docker-image.yml
Outdated
| ./dev/docker/build-docker.sh --platform all --type ${image_type} --image ${image_name} --tag ${{ github.event.inputs.version }} --latest | ||
| else | ||
| echo "Doesn't publish latest tag" | ||
| ./dev/docker/build-docker.sh --platform all --type ${image_type} --image ${image_name} --tag "${tag_name}-${{ github.event.inputs.version }}" |
There was a problem hiding this comment.
This if...else... is not correct, we should always build the image with tag names, right?
There was a problem hiding this comment.
updated with full_tag_name
jerryshao
reviewed
Jan 17, 2025
.github/workflows/docker-image.yml
Outdated
| echo "Publish tag ${full_tag_name}, doesn't update latest." |
There was a problem hiding this comment.
Remove this ", doesn't update latest", it is not useful.
jerryshao
reviewed
Jan 17, 2025
.github/workflows/docker-image.yml
Outdated
| @@ -115,8 +126,16 @@ jobs: | |||
| sudo rm -rf /usr/local/lib/android | |||
| sudo rm -rf /opt/hostedtoolcache/CodeQL | |||
|
|
|||
| if [[ "${image_type}" == "gravitino" || "${image_type}" == "iceberg-rest-server" ]]; then | |||
| ./dev/docker/build-docker.sh --platform all --type ${image_type} --image ${image_name} --tag ${{ github.event.inputs.version }} --latest | |||
| if [[ -n "${tag_name}" ]];then | |||
There was a problem hiding this comment.
Can you add a whitespace after ";"
jerryshao
reviewed
Jan 17, 2025
docs/publish-docker-images.md
Outdated
Comment on lines
33
to
34
| 7. If you want to update the latest tag, select the box for `Whether to update the latest tag`. | ||
| 7. Wait for the workflow to complete. You can see a new Docker image shown in the [Apache Docker Hub](https://hub.docker.com/u/apache) repository. |
There was a problem hiding this comment.
Can you change the sequence number, the number "7" is duplicated.
jerryshao
approved these changes
Jan 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
…atest tag. (#6318) ### What changes were proposed in this pull request? add an flag to control whether update docker latest tag. <img width="336" alt="image" src="https://github.com/user-attachments/assets/dc2b122a-b1bf-4e42-9f90-717ac6cd55ef" /> ### Why are the changes needed? Fix: #6300 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? test in whether update latest tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add an flag to control whether update docker latest tag.
Why are the changes needed?
Fix: #6300
Does this PR introduce any user-facing change?
no
How was this patch tested?
test in whether update latest tag