Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-36956][transform] Append NOT NULL attribute to PK columns #3815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-36956][transform] Append NOT NULL attribute to PK columns #3815

wants to merge 1 commit into from

Conversation

yuxiqian
Copy link
Contributor

This closes FLINK-36956 by appending NOT NULL attribute to columns that declared as Primary Keys.

@yuxiqian
[FLINK-36956][transform] Append NOT NULL attribute to PK columns
a4db562 
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>

# Conflicts:
#	flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposerITCase.java
#	flink-cdc-composer/src/test/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposerLenientITCase.java
@yuxiqian
Copy link
Contributor Author

@lvyanquan @Shawn-Hx PTAL

@github-actions github-actions bot added docs Improvements or additions to documentation composer runtime labels Dec 25, 2024
lvyanquan
lvyanquan approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvyanquan lvyanquan lvyanquan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
composer docs Improvements or additions to documentation reviewed runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuxiqian @lvyanquan