-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[constructed-inventory] Constructed inventory as alternative to smart inventory #13303
[constructed-inventory] Constructed inventory as alternative to smart inventory #13303
Conversation
1ec1feb
to
78f625f
Compare
78f625f
to
ec982bd
Compare
b1a3703
to
7bd0b65
Compare
7bd0b65
to
8357664
Compare
Add in required setting about empty groups
8357664
to
dd8c9f8
Compare
Co-authored-by: Rick Elrod <rick@elrod.me>
@@ -1709,8 +1704,17 @@ def get_related(self, obj): | |||
labels=self.reverse('api:inventory_label_list', kwargs={'pk': obj.pk}), | |||
) | |||
) | |||
if obj.kind in ('', 'constructed'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if these are ones that shouldn't show for "smart" inventory should we make this if statement reflect the condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean change this to obj.kind != 'smart'
?
SUMMARY
Connect #13447
Replaces first draft of #13214
ISSUE TYPE
Second Draft
This was a full Proof-of-Concept that can replicate the steps outlined in the CLI-based demo here:
https://github.com/AlanCoding/Ansible-inventory-file-examples/tree/master/issues/AWX371
It has been edited since then, and that is no longer entirely the functionality.
Key changes with this version:
Third Draft
This will be continually edited as the shape of the feature changes.
Key changes with this version:
key TODOs:
--limit
to inventory sourcesISSUE TYPE
COMPONENT NAME