Skip to content

Commit

Permalink
nox pip-compile: don't use env to pass nox args
Browse files Browse the repository at this point in the history
Using env here messes up the quoting for the args passed from the
calling workflows. Now that workflow_dispatch is disabled for the
reusable workflow, it should be safe to use GHA workflow templating
directly.
  • Loading branch information
gotmax23 committed Jan 24, 2024
1 parent e9889f2 commit 478cdbf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/reusable-pip-compile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,9 @@ jobs:
# Ensure the latest pip version is used
VIRTUALENV_DOWNLOAD: '1'
#
nox_args: "${{ inputs.nox-args }}"
run: |
set -x
nox ${nox_args}
nox ${{ inputs.nox-args }}
- name: Push new dependency versions and create a PR
env:
GITHUB_TOKEN: ${{ steps.create_token.outputs.token }}
Expand Down

0 comments on commit 478cdbf

Please sign in to comment.