Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: default value for controller should match bind address used for the mng interface #277

Merged
merged 1 commit into from
Dec 3, 2024
Merged

apps: default value for controller should match bind address used for the mng interface #277

merged 1 commit into from
Dec 3, 2024

Conversation

rpelisse
Copy link
Contributor

@rpelisse rpelisse commented Nov 6, 2024

No description provided.

@rpelisse rpelisse self-assigned this Nov 6, 2024
@rpelisse rpelisse marked this pull request as draft November 6, 2024 10:13
@rpelisse rpelisse marked this pull request as ready for review November 6, 2024 14:13
@rpelisse rpelisse added the enhancement New feature or request label Nov 27, 2024
guidograzioli
guidograzioli approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@guidograzioli guidograzioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rpelisse rpelisse changed the title apps: default value for controller should match ip of mng addr apps: default value for controller should match bind address used for the mng interface Dec 3, 2024
@rpelisse rpelisse merged commit 064c77b into main Dec 3, 2024
15 checks passed
@rpelisse rpelisse deleted the def_apps_controller_to_bind branch December 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidograzioli guidograzioli guidograzioli approved these changes

Assignees

@rpelisse rpelisse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpelisse @guidograzioli