Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/migrate esxi maintenance mode #99

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mikemorency
Copy link
Collaborator

SUMMARY

Migrating the community.vmware.vmware_maintenancemode module to here.
The functionality is the same, although one or two input options have been renamed for clarity

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

esxi_maintenance_mode

@mikemorency
Copy link
Collaborator Author

mikemorency commented Jan 8, 2025

i am not sure why that test is failing. it looks like an unrelated error. ill re-run it later

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 33.80282% with 47 lines in your changes missing coverage. Please review.

Project coverage is 28.21%. Comparing base (b50c216) to head (510bb52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/esxi_maintenance_mode.py 34.84% 43 Missing ⚠️
plugins/module_utils/_module_pyvmomi_base.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   28.04%   28.21%   +0.16%     
==========================================
  Files          31       32       +1     
  Lines        2350     2421      +71     
  Branches      426      438      +12     
==========================================
+ Hits          659      683      +24     
- Misses       1691     1738      +47     
Flag Coverage Δ
sanity 28.21% <33.80%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant