-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds instructions to deploy locally without Cloud Build. #105
base: master
Are you sure you want to change the base?
Conversation
525d0f4
to
ec5b86e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the style and gave optional suggestions
Co-authored-by: Caetano Colin <164910343+caetano-colin@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@amandakarina how did you run the 4-projects step? in my case it was not working because in module "gcp_projects_state_bucket" {
source = "terraform-google-modules/cloud-storage/google//modules/simple_bucket"
version = "~> 6.0"
name = "${var.bucket_prefix}-${module.seed_bootstrap.seed_project_id}-gcp-projects-tfstate"
project_id = module.seed_bootstrap.seed_project_id
location = var.default_region
force_destroy = var.bucket_force_destroy
encryption = {
default_kms_key_name = local.state_bucket_kms_key
}
depends_on = [module.seed_bootstrap.gcs_bucket_tfstate]
} I was able to run by creating the module above in a separate file, have you done something different? |
Here is a PR to your branch The issue addressed in the comment above is not contemplated in this PR |
Fixes business_unit_2 commands
631c5b6
to
9e038ef
Compare
b796b10
to
91b1f2a
Compare
The projects state bucket creation was moved from |
After testing your PR, here are some key points:
|
PR: #109 |
add more instructions on sa.tf
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
1958866
to
5adbebd
Compare
TODOs: