Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploring some style changes #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anaximander
Copy link

This is kind of a hodgepodge mix of stuff. Some notable changes include:

  • Downloaded fontawesome css + google fonts so they can be served without adding a network-bound dependency, and also to preserve the privacy of users.
  • Added missing dependencies (axios, react, react-dom, dev: react-scripts)
  • (Lossily) compressed wine glass "spinner" gif to ~650kb (from ~1MB)
  • Added more defaults and stricter validations on bottle form.
  • Updated styles here and there (feel free to keep all/any/none, I was just experimenting).
  • Moved BottleFilter into Bottle component (since it seemed BottleFilter wasn't generally usable outside of that context anyway).

Code quality isn't perfect but I don't think I broke anything. I also don't really like having to put images under the src directory, but webpack won't compile as-is otherwise. Might want to split App.css into several files, and put some of them under public so those images can be moved into public also. Let me know if you want me to do that (or any other code-cleanup) if you decide you want to merge this.

@anaximander
Copy link
Author

BTW, I grabbed those background images from https://www.toptal.com/designers/subtlepatterns/. If you end up using any of them, we should just make sure to give credit to the source. See https://www.toptal.com/designers/subtlepatterns/faq/.

@anaximander
Copy link
Author

I also played around with different messages for the various "filter states" in the Bottles component. Give it a try and hopefully it will be self-explanatory. I think that kind of basic feedback as the user interacts with the search input is really helpful in understanding what they're doing, and results in a better UX.

@aloten aloten force-pushed the main branch 2 times, most recently from c4e6870 to baf2818 Compare December 8, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant